Contracts: Reuse module when validating

[pgherveou]

Reuse wasmi Module when validating.
Prepare the code for 0.32 and the addition of Module::new_unchecked

[pgherveou]

bot bench substrate-pallet --pallet=pallet_contracts

[command-bot]

@pgherveou https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5610229 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 24-8d3b1b3d-6bbb-42cc-b673-474c0d48b657 to cancel this command or bot cancel to cancel all commands in this pull request.

[command-bot]

@pgherveou Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5610229 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5610229/artifacts/download.

[pgherveou]

bot bench substrate-pallet --pallet=pallet_contracts

[command-bot]

@pgherveou https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5610548 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 25-16d57403-e6b7-4490-b596-27c5f7b26aef to cancel this command or bot cancel to cancel all commands in this pull request.

[command-bot]

@pgherveou Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5610548 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5610548/artifacts/download.

[pgherveou]

https://weights.tasty.limo/compare?unit=weight&ignore_errors=true&threshold=10&method=asymptotic&repo=polkadot-sdk&old=master&new=pg/only-validate-when-uploading&path_pattern=substrate/frame/**/src/weights.rs,polkadot/runtime/*/src/weights/**/*.rs,polkadot/bridges/modules/*/src/weights.rs,cumulus/**/weights/*.rs,cumulus/**/weights/xcm/*.rs,cumulus/**/src/weights.rs

[paritytech-cicd-pr]

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5613501

[xermicus]

My only concern is that if there was a bug in the validation logic when the contract was uploaded and validated. Now this bug gets fixed and would reject the contract code. Are we fine with this?

[pgherveou]

My only concern is that if there was a bug in the validation logic when the contract was uploaded and validated. Now this bug gets fixed and would reject the contract code. Are we fine with this?

I think so, Note that even though it's laying up the ground work for Module:new_unchecked, it's not even using it here (since it's not available in the current wasmi version). This mainly fix an issue where we were wasting time loading the module twice when validating.

[Robbepop]

My only concern is that if there was a bug in the validation logic when the contract was uploaded and validated. Now this bug gets fixed and would reject the contract code. Are we fine with this?

This argument could be applied to every caching logic. What we could do is to provide a mechanism for chain users to off-chain scan for invalid uploaded contracts and contest them, initiating a validation and if they no longer validate the user is getting a reward, otherwise is punished.

[athei]

My only concern is that if there was a bug in the validation logic when the contract was uploaded and validated. Now this bug gets fixed and would reject the contract code. Are we fine with this?

This is already the case right now. If it gives us any performance benefit we will start skipping validation in a later PR as @pgherveou pointed out.

[pgherveou]

bot bench substrate-pallet --pallet=pallet_contracts

[command-bot]

@pgherveou "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts (https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5863083) was cancelled in #3789 (comment)

[pgherveou]

bot cancel 2-69da3527-bbc9-406f-95d6-bb76aec58651

[command-bot]

@pgherveou Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5863083 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5863083/artifacts/download.

[pgherveou]

bot bench substrate-pallet --pallet=pallet_contracts

[command-bot]

@pgherveou https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5865293 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 3-140e9fb7-e28a-4723-aba2-337b507240d6 to cancel this command or bot cancel to cancel all commands in this pull request.

[command-bot]

@pgherveou Command "$PIPELINE_SCRIPTS_DIR/commands/bench/bench.sh" --subcommand=pallet --runtime=dev --target_dir=substrate --pallet=pallet_contracts has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5865293 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5865293/artifacts/download.