Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove xcm::v3 from assets-common nits #4037

Merged
merged 15 commits into from
Apr 12, 2024
Merged

Remove xcm::v3 from assets-common nits #4037

merged 15 commits into from
Apr 12, 2024

Conversation

bkontur
Copy link
Contributor

@bkontur bkontur commented Apr 9, 2024

This PR mainly removes xcm::v3 stuff from assets-common to make it more generic and facilitate the transition to newer XCM versions. Some of the implementations here used hard-coded xcm::v3::Location, but now it's up to the runtime to configure according to its needs.

Additional/consequent changes:

  • penpal runtime uses now xcm::latest::Location for pallet_assets as AssetId, because we don't care about migrations here
    • it pretty much simplify xcm-emulator integration tests, where we don't need now a lots of boilerplate conversions:
      v3::Location::try_from(...).expect("conversion works")`
      
  • xcm-emulator tests
    • split macro impl_assets_helpers_for_parachain to the impl_assets_helpers_for_parachain and impl_foreign_assets_helpers_for_parachain (avoids using hard-coded xcm::v3::Location)

@bkontur bkontur added the R0-silent Changes should not be mentioned in any release notes label Apr 9, 2024
@bkontur bkontur marked this pull request as ready for review April 10, 2024 12:30
@bkontur bkontur requested a review from a team as a code owner April 10, 2024 12:30
Copy link
Contributor

@franciscoaguirre franciscoaguirre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better 🚀

Copy link
Contributor

@liamaharon liamaharon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This looks like it may impact downstream parachains though, is R0 an appropriate label?

@bkontur bkontur added T6-XCM This PR/Issue is related to XCM. T9-cumulus This PR/Issue is related to cumulus. and removed R0-silent Changes should not be mentioned in any release notes labels Apr 12, 2024
@bkontur
Copy link
Contributor Author

bkontur commented Apr 12, 2024

Looks good. This looks like it may impact downstream parachains though, is R0 an appropriate label?

yes, you're right, I added the prdoc.

also waiting for merging #3695 first

@bkontur bkontur enabled auto-merge April 12, 2024 21:05
@bkontur bkontur added this pull request to the merge queue Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T6-XCM This PR/Issue is related to XCM. T9-cumulus This PR/Issue is related to cumulus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants