CI: Prevent breaking backports #4812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
commented
Jun 17, 2024
bkchr
reviewed
Jun 28, 2024
Comment on lines
+49
to
+51
| wget -q https://github.com/cli/cli/releases/download/v2.51.0/gh_2.51.0_linux_amd64.tar.gz -O gh.tar.gz && \ | ||
| tar -xzf gh.tar.gz && mv gh_2.51.0_linux_amd64/bin/gh /usr/local/bin/gh && rm gh.tar.gz | ||
| chmod +x /usr/local/bin/gh |
There was a problem hiding this comment.
https://github.com/actions/github-script#comment-on-an-issue maybe we could use this?
There was a problem hiding this comment.
I tried it, but this and similar actions dont allow to simply edit the last comment. The gh cli has a --edit-last flag to avoid spam in the merge request that just amends it.
Alternative is to use the gh API and figure out the last comment id, and then editing that id. Surely more difficult than this one command.
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Morganamilo
approved these changes
Jul 25, 2024
alvicsam
approved these changes
Jul 25, 2024
EgorPopelyaev
approved these changes
Jul 26, 2024
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
- Prevent `major` changes to be merged into a `stable` branch. - Place a comment on backport MRs to provide context of what it means. Comment looks like this:  --------- Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
ggwpez
added a commit
that referenced
this pull request
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
majorchanges to be merged into astablebranch.Comment looks like this: