pallet-membership should implement ContainsLengthBound #4865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
User @Aideepakchaudhary, please sign the CLA here. |
bkchr
approved these changes
Jun 24, 2024
bkchr
added
R0-silent
seadanda
approved these changes
Jun 24, 2024
seadanda
reviewed
Jun 24, 2024
|
Review required! Latest push from author must always be reviewed |
Aideepakchaudhary
force-pushed
the
master
branch
2 times, most recently
from
ded635f
to
0c8e3ba
Compare
bkchr
approved these changes
Jun 24, 2024
Merged
via the queue into
paritytech:master
with commit Jun 24, 2024
fed81f7
155 of 158 checks passed
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
### ISSUE Link to the issue: paritytech#1143 Deliverables - Implement trait `ContainsLengthBound` for pallet-membership ### Test Outcomes ___ Successful tests by running `cargo test -p pallet-membership --features runtime-benchmarks` running 22 tests test tests::__construct_runtime_integrity_test::runtime_integrity_tests ... ok test benchmark::bench_clear_prime ... ok test tests::add_member_works ... ok test tests::change_key_with_same_caller_as_argument_changes_nothing ... ok test tests::change_key_works ... ok test benchmark::bench_set_prime ... ok test benchmark::bench_remove_member ... ok test benchmark::bench_change_key ... ok test tests::change_key_works_that_does_not_change_order ... ok test benchmark::bench_reset_members ... ok test benchmark::bench_add_member ... ok test tests::genesis_build_panics_with_duplicate_members - should panic ... ok test benchmark::bench_swap_member ... ok test tests::query_membership_works ... ok test tests::prime_member_works ... ok test tests::test_genesis_config_builds ... ok test tests::remove_member_works ... ok test tests::migration_v4 ... ok test tests::swap_member_with_identical_arguments_changes_nothing ... ok test tests::swap_member_works_that_does_not_change_order ... ok test tests::swap_member_works ... ok test tests::reset_members_works ... ok test result: ok. 22 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s Doc-tests pallet_membership running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s --------- Co-authored-by: Bastian Köcher <git@kchr.de>
This was referenced Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISSUE
Link to the issue: #1143
Deliverables
ContainsLengthBoundfor pallet-membershipTest Outcomes
Successful tests by running
cargo test -p pallet-membership --features runtime-benchmarksrunning 22 tests
test tests::__construct_runtime_integrity_test::runtime_integrity_tests ... ok
test benchmark::bench_clear_prime ... ok
test tests::add_member_works ... ok
test tests::change_key_with_same_caller_as_argument_changes_nothing ... ok
test tests::change_key_works ... ok
test benchmark::bench_set_prime ... ok
test benchmark::bench_remove_member ... ok
test benchmark::bench_change_key ... ok
test tests::change_key_works_that_does_not_change_order ... ok
test benchmark::bench_reset_members ... ok
test benchmark::bench_add_member ... ok
test tests::genesis_build_panics_with_duplicate_members - should panic ... ok
test benchmark::bench_swap_member ... ok
test tests::query_membership_works ... ok
test tests::prime_member_works ... ok
test tests::test_genesis_config_builds ... ok
test tests::remove_member_works ... ok
test tests::migration_v4 ... ok
test tests::swap_member_with_identical_arguments_changes_nothing ... ok
test tests::swap_member_works_that_does_not_change_order ... ok
test tests::swap_member_works ... ok
test tests::reset_members_works ... ok
test result: ok. 22 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.01s
Doc-tests pallet_membership
running 0 tests
test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s