Balances Pallet: Emit events when TI is updated in currency impl

[mittal-parth]

Description

Previously, in the Currency impl, the implementation of pallet_balances was not emitting any instances of Issued and Rescinded events, even though the Fungible equivalent was.

This PR adds the Issued and Rescinded events in appropriate places in impl_currency along with tests.

Closes #4028

polkadot address: 5GsLutpKjbzsbTphebs9Uy4YK6gTN47MAaz6njPktidjR5cp

[cla-bot-2021]

User @mittal-parth, please sign the CLA here.

[github-actions]

Review required! Latest push from author must always be reviewed

[mittal-parth]

Sorry for the inconvenience @bkchr 🥲

[mittal-parth]

@bkchr Looks like there is an issue with the full_native_block_import_works test and the sanity check for running Import Benchmarks.

For the first one, there should be the Rescinded event added.

	EventRecord {
		phase: Phase::ApplyExtrinsic(1),
		event: RuntimeEvent::Balances(pallet_balances::Event::Rescinded {
			amount: fees * 2 / 10,
		}),
		topics: vec![],
	},

For the second one, there would 9 events per signed extrinsic because of the extra Issued event.

assert_eq!(
	kitchensink_runtime::System::events().len(),
	(self.block.extrinsics.len() - 2) * 9 + 2,
);

I would like to run these tests locally before pushing just to catch further errors. Is there a way to run them locally? Whenever I run cargo t full_native_block_import_works -- --exact, my system just hangs while building itself.

[bkchr]

@mittal-parth did you try to just compile staging-node-cli?

cargo test -p staging-node-cli full_native_block_import_works

Otherwise you maybe not have enough main memory? How much do you have?

[mittal-parth]

@mittal-parth did you try to just compile staging-node-cli?

cargo test -p staging-node-cli full_native_block_import_works

Tried this, same result :(

Otherwise you maybe not have enough main memory? How much do you have?

I have 20GB RAM and 8 GB swap space.

[bkchr]

Is your system freezing because it runs out of memory or what?

[mittal-parth]

Is your system freezing because it runs out of memory or what?

Yes looks like. It starts to hang at 90% memory usage (possibly even more, I force stopped it there). Should I try increasing the swap space?

Edit: I tried that. Bumped it from 8 to 30 GB. But even with that much space, when the RAM reached 90% and swap space reached about 50% of its limit, it crashed.

[kianenigma]

Your address for a tip please (https://github.com/paritytech/substrate-tip-bot)?

Also, please also adjust your PR description. You need to remove the template :)

[mittal-parth]

Thanks @kianenigma, I've updated the description :)

[kianenigma]

/tip small

[substrate-tip-bot]

@kianenigma A referendum for a small (20 DOT) tip was successfully submitted for @mittal-parth (5GsLutpKjbzsbTphebs9Uy4YK6gTN47MAaz6njPktidjR5cp on polkadot).

Referendum number: 971.

[substrate-tip-bot]

The referendum has appeared on Polkassembly.

[paritytech-cicd-pr]

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 1/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6753721