Sync status refactoring #5450
Merged
Sync status refactoring #5450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ingService::num_connected_peers()` method
|
@dmitry-markin another small one for you here |
dmitry-markin
requested changes
Aug 23, 2024
|
semver check is buggy, it found changes in |
dmitry-markin
approved these changes
Aug 26, 2024
@alvicsam can you look into this, please, or CC a more relevant person? |
|
Tried merging master, may be this will resolve the semver issue... |
Yep, it did. It seems to detect changes not just from this PR to |
lexnv
approved these changes
Aug 26, 2024
Merged
via the queue into
paritytech:master
with commit Aug 26, 2024
dd1aaa4
188 of 190 checks passed
ordian
added a commit
that referenced
this pull request
Aug 27, 2024
* master: (36 commits) Bump the ci_dependencies group across 1 directory with 2 updates (#5401) Remove deprecated calls in cumulus-parachain-system (#5439) Make the PR template a default for new PRs (#5462) Only log the propagating transactions when they are not empty (#5424) [CI] Fix SemVer check base commit (#5361) Sync status refactoring (#5450) Add build options to the srtool build step (#4956) `MaybeConsideration` extension trait for `Consideration` (#5384) Skip slot before creating inherent data providers during major sync (#5344) Add symlinks for code of conduct and contribution guidelines (#5447) pallet-collator-selection: correctly register weight in `new_session` (#5430) Derive `Clone` on `EncodableOpaqueLeaf` (#5442) Moving `Find FAIL-CI` check to GHA (#5377) Remove panic, as proof is invalid. (#5427) Reactive syncing metrics (#5410) [bridges] Prune messages from confirmation tx body, not from the on_idle (#5006) Change the chain to Rococo in the parachain template Zombienet config (#5279) Improve the appearance of crates on `crates.io` (#5243) Add initial version of `pallet_revive` (#5293) Update OpenZeppelin template documentation (#5398) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I was looking at the coupling between
SyncingEngine,SyncingStrategyand individual strategies I noticed a few things that were unused, redundant or awkward.The awkward change comes from paritytech/substrate#13700 where
num_connected_peersproperty was added toSyncStatusstruct just so it can be rendered in the informer. While convenient, the property didn't really belong there and was annoyingly set to0in some strategies and tonum_peersin others. I have replaced that with a property onSyncingServicethat already stored necessary information internally.Also
ExtendedPeerInfodidn't have a workingCloneimplementation due to lack of perfect derive in Rust and while I ended up not using it in the refactoring, I included fixed implementation for it in this PR anyway.While these changes are not strictly necessary for #5333, they do reduce coupling of syncing engine with syncing strategy, which I thought is a good thing.
Reviewing individual commits will be the easiest as usual.