frame pallet macro: fix span for error on wrong returned type. #5580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
approved these changes
Sep 5, 2024
bkchr
reviewed
Sep 9, 2024
Co-authored-by: Bastian Köcher <git@kchr.de>
muharem
approved these changes
Sep 9, 2024
Merged
via the queue into
paritytech:master
with commit Sep 9, 2024
aec2b10
201 of 203 checks passed
|
@ggwpez do we want to backport this? it happened to me multiple time |
ggwpez
added
the
A4-needs-backport
github-actions bot
pushed a commit
that referenced
this pull request
Sep 11, 2024
Explicitly give the types in some generated code so that the error shows up good when user code is wrong. --------- Co-authored-by: Bastian Köcher <git@kchr.de> (cherry picked from commit aec2b10)
ggwpez
added
A4-needs-backport
|
Successfully created backport PR for |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 16, 2024
Explicitly give the types in some generated code so that the error shows up good when user code is wrong. --------- Co-authored-by: Bastian Köcher <git@kchr.de> (cherry picked from commit aec2b10)
github-actions bot
pushed a commit
that referenced
this pull request
Sep 16, 2024
Explicitly give the types in some generated code so that the error shows up good when user code is wrong. --------- Co-authored-by: Bastian Köcher <git@kchr.de> (cherry picked from commit aec2b10)
|
Successfully created backport PR for |
ggwpez
pushed a commit
that referenced
this pull request
Sep 16, 2024
Backport #5580 into `stable2407` from gui1117. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
ggwpez
pushed a commit
that referenced
this pull request
Sep 17, 2024
Backport #5580 into `stable2409` from gui1117. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Guillaume Thiolliere <gui.thiolliere@gmail.com>
ggwpez
removed
the
A4-needs-backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly give the types in some generated code so that the error shows up good when user code is wrong.