Asset Hub: auto incremented asset id for trust backed assets #5687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joepetrowski
approved these changes
Sep 12, 2024
gpestana
reviewed
Sep 12, 2024
| @@ -1021,6 +1021,12 @@ pub type Migrations = ( | |||
| // unreleased | |||
| cumulus_pallet_xcmp_queue::migration::v4::MigrationToV4<Runtime>, | |||
| cumulus_pallet_xcmp_queue::migration::v5::MigrateV4ToV5<Runtime>, | |||
| // unreleased | |||
| pallet_assets::migration::next_asset_id::SetNextAssetId< | |||
| ConstU32<50_000_000>, | |||
There was a problem hiding this comment.
How about defining and naming a const under runtimes/constants/ instead of having this magic number here?
There was a problem hiding this comment.
it will be gone after the migration applied
Ank4n
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup auto incremented asset id to
50_000_000for trust backed assets.In order to align with Polkadot/Kusama Asset Hub - polkadot-fellows/runtimes#414
The next closes existing assets IDs in Rococo is
69_696_969, in Westend is88_228_866.Migration
Stakeholders: all clients providing asset creation functionality on Westend/Rococo Asset Hub
This change does not break the API but introduces a new constraint. It implements an auto-incremented ID strategy for Trust-Backed Assets (50 pallet instance indexes on both networks), starting at ID 50,000,000. Each new asset must be created with an ID that is one greater than the last asset created. The next ID can be fetched from the
NextAssetIdstorage item of the assets pallet. An emptyNextAssetIdstorage item indicates no constraint on the next asset ID and can serve as a feature flag for this release.