-
Notifications
You must be signed in to change notification settings - Fork 645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update solochain to use #[runtime] #5772
Open
Jan-Jan
wants to merge
13
commits into
master
Choose a base branch
from
runtime-macro
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jan-Jan
added
C1-mentor
A task where a mentor is available. Please indicate in the issue who the mentor could be.
I4-refactor
Code needs refactoring.
labels
Sep 19, 2024
bkchr
approved these changes
Sep 20, 2024
21 tasks
gupnik
approved these changes
Sep 21, 2024
ggwpez
reviewed
Sep 21, 2024
ggwpez
reviewed
Sep 21, 2024
ggwpez
reviewed
Sep 21, 2024
ggwpez
approved these changes
Sep 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C1-mentor
A task where a mentor is available. Please indicate in the issue who the mentor could be.
I4-refactor
Code needs refactoring.
R0-silent
Changes should not be mentioned in any release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#[frame::runtime]
Template
instead ofTemplateModule
Integration
solochain
template and documentationReview Notes
solochain
template from construct_runtime! to #[runtime].Template
is our new convention, and preferred overTemplateModule
.Out of scope
#[crate::runtime]
with#[frame_support::runtime]