staking miner: remove needless queue check (#6221)

* staking miner: remove needless queue check If the queue is full and the "mined solution" is better than solutions in the queue according to the "strategy" then the solution with worse score will be kicked out from the queue. Thus, the check can be removed completly. * fix compile warns
paritytech · Nov 8, 2022 · ee1a034 · ee1a034
1 parent b19973c
commit ee1a034
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/utils/staking-miner/src/main.rs b/utils/staking-miner/src/main.rs
@@ -253,7 +253,6 @@ enum Error<T: EPM::Config> {
 	AlreadySubmitted,
 	VersionMismatch,
 	StrategyNotSatisfied,
-	QueueFull,
 	Other(String),
 }
 

diff --git a/utils/staking-miner/src/monitor.rs b/utils/staking-miner/src/monitor.rs
@@ -120,9 +120,8 @@ async fn ensure_strategy_met<T: EPM::Config, B: BlockT>(
 		.map_err::<Error<T>, _>(Into::into)?
 		.unwrap_or_default();
 
-	// we check the queue here as well. Could be checked elsewhere.
-	if indices.len() as u32 >= max_submissions {
-		return Err(Error::<T>::QueueFull)
+	if indices.len() >= max_submissions as usize {
+		log::debug!(target: LOG_TARGET, "The submissions queue is full");
 	}
 
 	// default score is all zeros, any score is better than it.