This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Backport: Make ValidationPool accepts execution mode to run custom command or in process validation (#1622) #1675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forked at: 93f0029 Parent branch: origin/rococo-branch
…n process validation (#1622) Squashed commit of the following: commit 3eec1ef Author: Cecile Tonglet <cecile@parity.io> Date: Wed Sep 2 11:43:47 2020 +0200 CLEANUP Forked at: bf7ccb8 Parent branch: origin/master commit 50ba484 Author: Cecile Tonglet <cecile@parity.io> Date: Wed Sep 2 11:42:07 2020 +0200 Add test commit 33ced08 Author: Cecile Tonglet <cecile@parity.io> Date: Wed Sep 2 11:21:57 2020 +0200 Run validation inside the same process commit 4e113ba Author: Cecile Tonglet <cecile@parity.io> Date: Wed Sep 2 10:25:06 2020 +0200 Adapt code to review suggestions commit f46e7a7 Merge: 6301515 e2ebf25 Author: Cecile Tonglet <cecile@parity.io> Date: Wed Sep 2 10:03:04 2020 +0200 Merge commit e2ebf25 (no conflict) Parent branch: origin/master Forked at: bf7ccb8 commit 6301515 Merge: 7f57373 01ffc66 Author: Cecile Tonglet <cecile@parity.io> Date: Tue Aug 25 01:09:27 2020 +0200 Merge commit 01ffc66 (no conflict) Parent branch: origin/master Forked at: bf7ccb8 commit 7f57373 Merge: 1fd2987 00202d3 Author: Cecile Tonglet <cecile@parity.io> Date: Tue Aug 25 01:09:22 2020 +0200 Merge commit 00202d3 (conflicts) Parent branch: origin/master Forked at: bf7ccb8 commit 1fd2987 Merge: 41cb5b5 62cf5b9 Author: Cecile Tonglet <cecile@parity.io> Date: Tue Aug 25 01:05:23 2020 +0200 Merge commit 62cf5b9 (no conflict) Parent branch: origin/master Forked at: bf7ccb8 commit 41cb5b5 Author: Cecile Tonglet <cecile@parity.io> Date: Tue Aug 25 01:03:31 2020 +0200 Update service/src/lib.rs Co-authored-by: Bastian Köcher <bkchr@users.noreply.github.com> commit 8a5aa08 Author: Cecile Tonglet <cecile@parity.io> Date: Fri Aug 21 19:06:36 2020 +0200 WIP Forked at: bf7ccb8 Parent branch: origin/master commit b7a97df Author: Cecile Tonglet <cecile@parity.io> Date: Fri Aug 21 15:56:21 2020 +0200 Fix test commit e28eed7 Author: Cecile Tonglet <cecile@parity.io> Date: Fri Aug 21 15:37:13 2020 +0200 Update validation/src/validation_service/mod.rs commit 8c880f7 Author: Cecile Tonglet <cecile@parity.io> Date: Fri Aug 21 15:02:45 2020 +0200 Propagate test mode all the way down to ValidationPool commit d32b42a Author: Cecile Tonglet <cecile@parity.io> Date: Fri Aug 21 15:27:56 2020 +0200 Initial commit Forked at: bf7ccb8 Parent branch: origin/master
This reverts commit 93f0029.
cecton
added
B0-silent
* WIP Forked at: e916423 Parent branch: origin/rococo-branch * WIP Forked at: e916423 Parent branch: origin/rococo-branch * WIP Forked at: e916423 Parent branch: origin/rococo-branch * WIP Forked at: e916423 Parent branch: origin/rococo-branch * WIP Forked at: e916423 Parent branch: origin/rococo-branch * WIP Forked at: e916423 Parent branch: origin/rococo-branch * WIP Forked at: e916423 Parent branch: origin/rococo-branch * WIP Forked at: e916423 Parent branch: origin/rococo-branch * Apply suggestions from code review * WIP Forked at: e916423 Parent branch: origin/rococo-branch * WIP Forked at: e916423 Parent branch: origin/rococo-branch * WIP Forked at: e916423 Parent branch: origin/rococo-branch * CLEANUP Forked at: e916423 Parent branch: origin/rococo-branch * link in doc * doc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1622
Related to paritytech/cumulus#199
Also related to paritytech/cumulus#201 for the actual use
This change will make the polkadot test service use the "in-process" mode of the validation pool.
Also: