This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Use unbounded channel for local bitfields distribution #5518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstakhov
added
A0-please_review
github-actions
bot
removed
B0-silent
vstakhov
added
B0-silent
|
As discussed with Andrei, I don't think this is solving any issues. We can see in the heatmap, that some nodes don't receive all bitfields, while others do. This cannot be fixed by prioritizing sending of own bitfields. What we can do though, is increase the time we have for gossip (especially given that availability-distribution is fast), Andrei is testing that at the moment. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to address short-term issues described in paritytech/polkadot-sdk#825. It limits number of the unbounded messages per relay parent, however, a better sollution is to use priorities as described in paritytech/polkadot-sdk#824.