Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Replace async-std with tokio in PVF subsystem #6419

Merged
merged 23 commits into from
Jan 10, 2023
Merged

Replace async-std with tokio in PVF subsystem #6419

merged 23 commits into from
Jan 10, 2023

Commits on Dec 11, 2022

  1. Replace async-std with tokio in PVF subsystem

    @mrcnski
    mrcnski committed Dec 11, 2022
    Configuration menu
    Copy the full SHA
    ec204fa View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. Rework workers to use select! instead of a mutex 

    The improvement in code readability is more important than the thread overhead.
    @mrcnski
    mrcnski committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    3abc804 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary fuse

    @mrcnski
    mrcnski committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    5fcc67d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into m-cat/replace-async-std-pvf

    @mrcnski
    mrcnski committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    1574561 View commit details
    Browse the repository at this point in the history

  4. Add explanation for expect()

    @mrcnski
    mrcnski committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    451fae0 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2022

  1. Update node/core/pvf/src/worker_common.rs 

    Co-authored-by: Bastian Köcher <info@kchr.de>
    @mrcnski @bkchr
    mrcnski and bkchr committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    fc4c28b View commit details
    Browse the repository at this point in the history

  2. Update node/core/pvf/src/worker_common.rs 

    Co-authored-by: Bastian Köcher <info@kchr.de>
    @mrcnski @bkchr
    mrcnski and bkchr committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    1dde78b View commit details
    Browse the repository at this point in the history

  3. Address some review comments

    @mrcnski
    mrcnski committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    da31a48 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/m-cat/replace-async-std-pvf' int… 

    …o m-cat/replace-async-std-pvf
    @mrcnski
    mrcnski committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    35a0c79 View commit details
    Browse the repository at this point in the history

  5. Shutdown tokio runtime

    @mrcnski
    mrcnski committed Dec 18, 2022
    Configuration menu
    Copy the full SHA
    e1c2cf3 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2022

  1. Run cargo fmt

    @mrcnski
    mrcnski committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    077a123 View commit details
    Browse the repository at this point in the history

  2. Add a small note about retries

    @mrcnski
    mrcnski committed Dec 19, 2022
    Configuration menu
    Copy the full SHA
    e0d4b9e View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2022

  1. Merge branch 'master' into m-cat/replace-async-std-pvf

    @mrcnski
    mrcnski committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    2353747 View commit details
    Browse the repository at this point in the history

  2. Fix up merge

    @mrcnski
    mrcnski committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    28d4062 View commit details
    Browse the repository at this point in the history

  3. Rework cpu_time_monitor_loop to return when other thread finishes

    @mrcnski
    mrcnski committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    3964aca View commit details
    Browse the repository at this point in the history

  4. Add error string to PrepareError::IoErr variant

    @mrcnski
    mrcnski committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    7057518 View commit details
    Browse the repository at this point in the history

  5. Log when artifacts fail to prepare

    @mrcnski
    mrcnski committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    e6ba098 View commit details
    Browse the repository at this point in the history

  6. Fix cpu_time_monitor_loop; fix test

    @mrcnski
    mrcnski committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    e094f80 View commit details
    Browse the repository at this point in the history

  7. Fix text

    @mrcnski
    mrcnski committed Dec 20, 2022
    Configuration menu
    Copy the full SHA
    c09377a View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2022

  1. Fix a couple of potential minor data races. 

    First data race was due to logging in the CPU monitor thread even if the
job (other thread) finished. It can technically finish before or after the log.

Maybe best would be to move this log to the `select!`s, where we are guaranteed
to have chosen the timed-out branch, although there would be a bit of
duplication.

Also, it was possible for this thread to complete before we executed
`finished_tx.send` in the other thread, which would trigger an error as the
receiver has already been dropped. And right now, such a spurious error from
`send` would be returned even if the job otherwise succeeded.
    @mrcnski
    mrcnski committed Dec 22, 2022
    Configuration menu
    Copy the full SHA
    05d1865 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2023

  1. Merge branch 'master' into m-cat/replace-async-std-pvf

    @mrcnski
    mrcnski committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    b0c2434 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2023

  1. Merge branch 'master' into m-cat/replace-async-std-pvf

    @mrcnski
    mrcnski committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    5cc477c View commit details
    Browse the repository at this point in the history

  2. Update Cargo.lock

    @mrcnski
    mrcnski committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    0f4ac06 View commit details
    Browse the repository at this point in the history