This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Don't print "Discovered new external" line for private IPs #10055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
added
A0-please_review
bkchr
approved these changes
Oct 19, 2021
kpp
approved these changes
Oct 19, 2021
|
bot merge |
|
🤞 |
|
Error: Checks failed for 74f13b3 |
|
bot merge |
|
Waiting for commit status. |
|
Merge cancelled due to error. Error: Checks failed for 74f13b3 |
|
Yeah it's clearly this PR that introduces a regression in the trie performances. |
|
I'll just merge manually. |
23 tasks
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reason why we print this line in the first place is to indicate to node operators what their external IP address is. It is therefore questionable to print it when the IP address isn't going to reach the DHT anyway.
This should considerably reduce the spam of logs.