Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

expose substrate-cli service #10229

Merged
merged 2 commits into from
Nov 11, 2021
Merged

expose substrate-cli service #10229

merged 2 commits into from
Nov 11, 2021

Conversation

sander2
Copy link
Contributor

@sander2 sander2 commented Nov 10, 2021

This exposes rpc_handlers, which is needed to use this in SubXt integration tests (paritytech/subxt#318)

bkchr
bkchr reviewed Nov 10, 2021
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to run cargo fmt

bin/node/cli/src/service.rs Outdated Show resolved Hide resolved
@bkchr bkchr added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Nov 11, 2021
@bkchr
Copy link
Member

bkchr commented Nov 11, 2021

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot
Copy link

Bot will approve on the behalf of @bkchr, since they are a team lead, in an attempt to reach the minimum approval count

@paritytech-processbot paritytech-processbot bot merged commit 2ab7698 into paritytech:master Nov 11, 2021
ordian added a commit that referenced this pull request Nov 12, 2021
@ordian
Merge branch 'master' into 3x8_update_nightly_fix_fmt
5cf1cc8 
* master: (27 commits)
  Bump rustversion from 1.0.4 to 1.0.5 (#10243)
  Kill the light client, CHTs and change tries. (#10080)
  tuple to struct event variants (#10206)
  Bump thiserror from 1.0.26 to 1.0.30 (#10240)
  Warn about usage of pallet collective set members call. (#10156)
  Bump git2 from 0.13.22 to 0.13.23 (#10238)
  Add group name in task metrics  (#10196)
  Bump proc-macro-crate from 1.0.0 to 1.1.0 (#10237)
  Bump parity-util-mem from 0.10.0 to 0.10.2 (#10236)
  Bump substrate-bip39 from 0.4.2 to 0.4.4 (#10213)
  Upgrade jsonrpsee to v0.4.1 (#10022)
  expose substrate-cli service (#10229)
  Intend to reactivate cargo-unleash check (#10167)
  CI: build docs with deps (#9884)
  use CountedMap in pallet-bags-list (#10179)
  Move all example pallets under `examples` folder. (#10215)
  Upgrade wasm builder (#10226)
  upgrade ss58-registry with additional networks. (#10224)
  move wiki -> docs (#10225)
  new remote-ext mode: (#10192)
  ...
grishasobol pushed a commit to gear-tech/substrate that referenced this pull request Mar 28, 2022
@sander2 @grishasobol
expose substrate-cli service (paritytech#10229)
dafd6de 
* expose substrate-cli service

* chore: undo change to new_full (since new_full_base is exposed already)
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@sander2 @ark0f
expose substrate-cli service (paritytech#10229)
f7cdb3a 
* expose substrate-cli service

* chore: undo change to new_full (since new_full_base is exposed already)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

@paritytech-processbot paritytech-processbot paritytech-processbot approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sander2 @bkchr