This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
contracts: Adapt dry-run runtime APIs to WeightV2 #12429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athei
added
A0-please_review
cmichi
approved these changes
Oct 5, 2022
kianenigma
approved these changes
Oct 6, 2022
|
bot merge |
This was referenced Oct 22, 2022
Closed
This was referenced Nov 10, 2022
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #12421
We also to accept
Weightin our runtime apis so that theproof_sizecan be passed when dry-running. Additionally, we make the argument optional so that the runtime can choose a sensible default.While doing so we move the runtime api into the main crate. Since there are no RPCs using it anymore we don't need it to be in its own crate.
cumulus companion: paritytech/cumulus#1736