This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
try-runtime: add cli option --export-proof #12539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggwpez
reviewed
Oct 20, 2022
|
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
A5-stale
stale
bot
removed
the
A5-stale
|
This PR is not stale, I'm still working on it. |
|
@ggwpez can we get another review ? We just merged master again |
ggwpez
reviewed
Dec 15, 2022
| @@ -31,13 +38,6 @@ sp-weights = { version = "4.0.0", path = "../../../../primitives/weights" } | |||
| frame-try-runtime = { optional = true, path = "../../../../frame/try-runtime" } | |||
| substrate-rpc-client = { path = "../../rpc/client" } | |||
|
|
|||
| parity-scale-codec = "3.0.0" | |||
| hex = "0.4.3" | |||
There was a problem hiding this comment.
I think these deps were split off to the bottom since they are external.
ggwpez
added
A0-please_review
kianenigma
approved these changes
Dec 16, 2022
|
So can you still address the discussion with the dependencies please? |
Co-authored-by: Anton <anton.kalyaev@gmail.com>
Co-authored-by: Anton <anton.kalyaev@gmail.com>
Co-authored-by: Anton <anton.kalyaev@gmail.com>
Co-authored-by: Anton <anton.kalyaev@gmail.com>
@ggwpez Sorry for the delay, I was on vacation, now it's done. |
melekes
approved these changes
Dec 29, 2022
|
bot merge |
ltfschoen
pushed a commit
to ltfschoen/substrate
that referenced
this pull request
Feb 22, 2023
* try-runtime: add cli option --export-proof * extract proof in raw json format * fix build * fix(try-runtime execute-block): wrong block parsing * fmt * apply suggestions * Update utils/frame/try-runtime/cli/src/lib.rs Co-authored-by: Anton <anton.kalyaev@gmail.com> * Update utils/frame/try-runtime/cli/src/lib.rs Co-authored-by: Anton <anton.kalyaev@gmail.com> * Update utils/frame/try-runtime/cli/src/lib.rs Co-authored-by: Anton <anton.kalyaev@gmail.com> * Update utils/frame/try-runtime/cli/src/lib.rs Co-authored-by: Anton <anton.kalyaev@gmail.com> * split off external dependencies * fmt * fix try-runtime compilation Co-authored-by: Anton <anton.kalyaev@gmail.com>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* try-runtime: add cli option --export-proof * extract proof in raw json format * fix build * fix(try-runtime execute-block): wrong block parsing * fmt * apply suggestions * Update utils/frame/try-runtime/cli/src/lib.rs Co-authored-by: Anton <anton.kalyaev@gmail.com> * Update utils/frame/try-runtime/cli/src/lib.rs Co-authored-by: Anton <anton.kalyaev@gmail.com> * Update utils/frame/try-runtime/cli/src/lib.rs Co-authored-by: Anton <anton.kalyaev@gmail.com> * Update utils/frame/try-runtime/cli/src/lib.rs Co-authored-by: Anton <anton.kalyaev@gmail.com> * split off external dependencies * fmt * fix try-runtime compilation Co-authored-by: Anton <anton.kalyaev@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a cli option
--export-prooffortry-runtimesubcommand to be able to extract the storage proof in a binary file.The goal is to be able to analyze the content of a storage proof, obtained for example after the execution of the subcommand
try-runtime on-runtime-upgradeto understand which data are inserted in the proof by a migration.