This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Relax Copy to Clone for AssetId #12731
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilescope
added
B3-apinoteworthy
C1-low
|
Maybe this is not needed - |
I agree focusing on v3 is probably the best strategy as it's already needed for related goals with the second Assets pallet. |
|
if we're doing #12740 then maybe we should as then its not delayed by xcm3. We can have it all hit master which is going to be less complicated. |
|
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
A5-stale
|
I think we can get away with keeping copy. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the bridgehub we want to use a second Asset pallet for bridged assets. The suggestion is to have the
AssetIdof this instance be aMultiLocation. HoweverMultilocationis notCopy, so this PR is exploring the impact of relaxing theCopybound to only requireClone.cumulus companion: paritytech/cumulus#1900