Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Move update-node-template to Polkadot's pipeline #13100

Merged

Conversation

joao-paulo-parity
Copy link
Contributor

@joao-paulo-parity joao-paulo-parity commented Jan 9, 2023

According to https://github.com/paritytech/release-engineering/issues/142

The desired behaviour is that this job should be triggered only once when the final release tag is created.

The simplest solution I found for that requirement entails moving the job to Polkadot's pipeline and triggering it on the tags of that repository (paritytech/polkadot#6522).

Alternatively we could keep the job here and trigger a remote pipeline from Polkadot to this repository (example), but the extra complexity of that solution seems unwarranted for this script.

close https://github.com/paritytech/release-engineering/issues/142

@joao-paulo-parity joao-paulo-parity requested a review from a team as a code owner January 9, 2023 08:53
@joao-paulo-parity joao-paulo-parity added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit. labels Jan 9, 2023
@paritytech-ci paritytech-ci requested a review from a team January 9, 2023 12:49
@joao-paulo-parity
Copy link
Contributor Author

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 946507b into paritytech:master Jan 11, 2023
@joao-paulo-parity joao-paulo-parity deleted the node-template branch January 11, 2023 09:03
rossbulat pushed a commit that referenced this pull request Jan 11, 2023
@nuke-web3
Copy link
Contributor

0.9.37 did not trigger a PR downstream, this is why correct?

Unless the overall release strategy is changing, we want to keep this happening for sure @joao-paulo-parity .
cc @sacha-l @lisa-parity

@joao-paulo-parity
Copy link
Contributor Author

joao-paulo-parity commented Feb 7, 2023

0.9.37 did not trigger a PR downstream

The job to produce the PR was triggered (https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2282467), but it appears there's a problem with the script. I'll submit a fix shortly.

EDIT: See https://github.com/substrate-developer-hub/substrate-parachain-template/issues/143#issuecomment-1420736469

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D2-notlive 💤 PR contains changes in a runtime directory that is not deployed to a chain that requires an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants