Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

dex quote bugfix #13191

Merged
merged 1 commit into from
Jan 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions frame/dex/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -701,9 +701,7 @@ pub mod pallet {
let balance1 = Self::get_balance(&pool_account, asset1);
let balance2 = Self::get_balance(&pool_account, asset2);
if !balance1.is_zero() {
let (reserve1, reserve2) =
if asset1 == pool_asset1 { (balance1, balance2) } else { (balance2, balance1) };
Self::quote(&amount, &reserve1, &reserve2).ok()
Self::quote(&amount, &balance1, &balance2).ok()
} else {
None
}
Expand Down
3 changes: 3 additions & 0 deletions frame/dex/src/tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -402,6 +402,9 @@ fn quote_price_should_work() {
));

assert_eq!(Dex::quote_price(None, Some(2), 3000), Some(60));

// Check inverse:
assert_eq!(Dex::quote_price(Some(2), None, 60), Some(3000));
});
}

Expand Down