This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Adds example for dev_mode and updates doc #13944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gupnik
added
A0-please_review
ggwpez
reviewed
Apr 18, 2023
kianenigma
reviewed
Apr 19, 2023
| Ok(()) | ||
| } | ||
|
|
||
| #[pallet::call_index(1)] |
There was a problem hiding this comment.
I think making this optional is also a clear good next step for dev-mode 👍
kianenigma
reviewed
Apr 19, 2023
kianenigma
approved these changes
Apr 19, 2023
There was a problem hiding this comment.
good start, although I hope we can also revise both this and example/ basic in a more fundamental manner -- I think a lot of the existing features that are put into these example pallets are somewhat nonsensical and could be improved.
I can imagine set of 4 example pallets:
template: a shell pallet, it is your starting point.basic: one that has a small set of features, akin to a smart contractkitchensink: one that has ALL of the features.dev-mode: meant to demonstrate the difference between the latter anddev-mode.
I can actually work on this myself as a part of doc-revamp.
Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
…ubstrate into gupnik/optional_hashers_doc
15 tasks
nathanwhit
pushed a commit
to nathanwhit/substrate
that referenced
this pull request
Jul 19, 2023
* Adds example for dev_mode and updates doc * Addresses review comments * Update frame/examples/dev-mode/src/lib.rs Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com> * Addresses review comment --------- Co-authored-by: Kian Paimani <5588131+kianenigma@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #13815.