-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Conversation
…te into make-examples-compile
…/substrate into make-examples-compile
srml/balances/src/lib.rs
Outdated
//! T::BlockNumber::max_value(), | ||
//! WithdrawReasons::all() | ||
//! ); | ||
//! // <Ledger<T>>::insert(controller, ledger); // Commented out as we don't have acces to Staking's storage here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use a different example here? Or just drop the last line?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I looked a lot. The problem is the nature of Currency
in general, in that if you are locking or transferring funds, you are probably doing a lot of checks and/or writing to storage because the currency event was in response to some other event (like seconding a referendum). I'm OK with removing it.
consensus compiles at least but I think the doc example could be improved and maybe some removed |
In staking, I removed a lot of examples that were just taken from the test file and require a large mock environment to compile. Open to re-introducing them if people think they are useful. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overly indented example
Make documentation examples compile for the following modules: