This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Fix #5516 #5560
Merged
Fix #5516 #5560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
added
A0-please_review
|
I also added as part of this PR:
I did that to save efforts, but if these changes are invasive or debatable, I can split the PR. |
twittner
reviewed
Apr 7, 2020
Co-Authored-By: Toralf Wittner <tw@dtex.org>
twittner
approved these changes
Apr 8, 2020
|
@gnunicorn How does that work? Do I merge this now? |
lamafab
pushed a commit
to lamafab/substrate
that referenced
this pull request
Jun 16, 2020
…adot#986 (paritytech#982) * Companion PR to paritytech#5560 * Set priorities. * Update substrate. * Fix tests. * Update Substrate * Companion of SignedExtension refactor (paritytech#5540) Co-authored-by: Tomasz Drwięga <tomasz@parity.io> Co-authored-by: Alexander Theißen <alexander.theissen@parity.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5516
#5516 happens when node A writes its status message on the legacy substream followed by writing a notification on the notification substream. Because messages are temporarily buffered and because we always poll the notifications substreams first, we effectively send the notification before sending the status message.
The fix is therefore to change the order of polling.
Note that there is clearly a design issue here, as we should not rely on the ordering of messages being sent between substreams. This design is done so because of backwards compatibility reasons, and it will be fixed in the future by removing the legacy code altogether.
While I agree that the fix isn't super robust, the test I added should guarantee that we don't have any regression in the future.
cc @bkchr
polkadot companion: paritytech/polkadot#982