This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Add metrics about block requests #5811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaka
added
A0-please_review
twittner
approved these changes
Apr 28, 2020
mxinden
approved these changes
Apr 28, 2020
| }); | ||
| }, | ||
| block_requests::SendRequestOutcome::Replaced { request_duration, .. } => { | ||
| self.events.push(BehaviourOut::RequestFinished { |
There was a problem hiding this comment.
This could deviate the finished histogram quite a bit as requests might take < 1ms, right? Would it make sense to differentiate between failure and success in the histogram?
Feel free to ignore.
Co-Authored-By: Max Inden <mail@max-inden.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds metrics to block requests.
This PR does the following:
BlockRequest::send_requestnow returns aSendRequestOutcomethat indicates what happened (did we override a previous request?).block_requests::Event::AnsweredRequestevent to notify that we have processed a request from the remote.request_durationfields toblock_requests::Eventto indicate the time between request and the response, or the time before timeout.I deployed this PR on my node, and by looking at
polkadot_sub_libp2p_requests_out_started_total - polkadot_sub_libp2p_requests_out_finished_countI can confirm that #5794 works as intended.