Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Use log level error to report telemetry #8097

Merged
1 commit merged into from
Feb 10, 2021
Merged

Conversation

cecton
Copy link
Contributor

@cecton cecton commented Feb 10, 2021

Please beware that if you do -loff,telemetry=trace it still fails!

./target/debug/substrate --dev --tmp --telemetry-url "ws://127.0.0.1:1337 10" -loff,telemetry=trace
2021-02-10 12:55:03.801  ERROR main telemetry: Could not initialize telemetry: the span could not be entered    
2021-02-10 12:55:03.807  ERROR tokio-runtime-worker telemetry: Received connection notifier for unknown node (/ip4/127.0.0.1/tcp/1337/ws). This is a bug.    

It just doesn't fail anymore for -lerror and -lwarn

Fixes: #8093

This fix the issue when running the node with -lwarn, the telemetry cannot be initialized properly.
@cecton cecton requested review from dvdplm and bkchr February 10, 2021 11:48
@github-actions github-actions bot added the A0-please_review Pull request needs code review. label Feb 10, 2021
@bkchr
Copy link
Member

bkchr commented Feb 10, 2021

As already discussed in element. @cecton will work after this on some pr to move telemetry out of this tracing infrastructure. Instead of doing this, we will pass a telemetry object around as we do for prometheus.

@bkchr bkchr requested a review from gnunicorn February 10, 2021 12:01
@cecton cecton added B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Feb 10, 2021
@gnunicorn
Copy link
Contributor

bot merge

@ghost
Copy link

ghost commented Feb 10, 2021

Trying merge.

@ghost ghost merged commit 12562bb into master Feb 10, 2021
@ghost ghost deleted the cecton-fix-telemetry-log-warn branch February 10, 2021 15:30
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Telemetry breaks when running with custom log levels
3 participants