Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Index type from Config trait #1074

Merged
merged 7 commits into from
Jul 20, 2023
Merged

Remove Index type from Config trait #1074

merged 7 commits into from
Jul 20, 2023

Commits on Jul 17, 2023

  1. remove config, doc tests are expected to fail (book not adjusted yet)

    @tadeohepperle
    tadeohepperle committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    67dfd34 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. make doc tests pass

    @tadeohepperle
    tadeohepperle committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    05cdd4d View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into tadeo-hepperle-remove-index-from-config

    @tadeohepperle
    tadeohepperle committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    37b1d62 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2023

  1. Merge branch 'master' into tadeo-hepperle-remove-index-from-config

    @jsdw
    jsdw committed Jul 19, 2023
    Configuration menu
    Copy the full SHA
    3ca2886 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Prevent bug when reusing type ids in hashing (#1075) 

    * practice TDD

* implement a hashmap 2-phases approach

* use nicer types

* add test for cache filling

* adjust test

---------

Co-authored-by: James Wilson <james@jsdw.me>
    @tadeohepperle @jsdw
    tadeohepperle and jsdw committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    94fe352 View commit details
    Browse the repository at this point in the history

  2. remove the unnecessary intos

    @tadeohepperle
    tadeohepperle committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    a3b2afd View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into tadeo-hepperle-remove-index-from-config

    @tadeohepperle
    tadeohepperle committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    3531a90 View commit details
    Browse the repository at this point in the history