Store type name of a field in event metadata #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascjones
reviewed
Sep 16, 2022
jsdw
reviewed
Sep 16, 2022
|
LGTM aside from my tiny nit and Andrew's suggestion! |
lexnv
reviewed
Sep 19, 2022
| @@ -457,7 +490,13 @@ impl TryFrom<RuntimeMetadataPrefixed> for Metadata { | |||
| fields: variant | |||
| .fields() | |||
| .iter() | |||
| .map(|f| (f.name().map(|n| n.to_owned()), f.ty().id())) | |||
| .map(|f| { | |||
| EventFieldMetadata::new( | |||
There was a problem hiding this comment.
nit: Maybe we could use something like impl From<Field<PortableForm>> here
lexnv
approved these changes
Sep 19, 2022
ascjones
approved these changes
Sep 20, 2022
This was referenced Sep 20, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fields in
EventMetadatanow also store name of a type specified in the pallet's source code.Required for #673 in
cargo-contract