add wasm support #700
add wasm support #700
Conversation
subxt/src/client/online_client.rs
Outdated
| #[cfg(any( | ||
| all(feature = "jsonrpsee-ws", not(target_arch = "wasm32")), | ||
| all(feature = "jsonrpsee-web", target_arch = "wasm32") | ||
| ))] |
There was a problem hiding this comment.
Should we have a check at the root lib.rs to make sure that somebody cannot enable both of these jsonrpsee features simultaneously?
What are the pros and cons for also having this target_arch check as well as just checking the features? It'd be nice if we could just check for a feature and not worry about the rest, for simplicity
There was a problem hiding this comment.
Should we have a check at the root lib.rs to make sure that somebody cannot enable both of these jsonrpsee features simultaneously?
Sure
What are the pros and cons for also having this target_arch check as well as just checking the features? It'd be nice if we could just check for a feature and not worry about the rest, for simplicity
It's my own fault in jsonrpsee i.e, it won't compile without the target_arch
There was a problem hiding this comment.
Ok that makes sense! Is it worth filing an issue/PR in jsonrpsee to tweak that so we can simplify here?
There was a problem hiding this comment.
yeah, I can take a look if it's possible to remove those
To avoid leaking `jsonrpsee-web` feature into the workspace
Co-authored by @Xanewok