Make working with nested queries a touch easier #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Andrew Jones <ascjones@gmail.com>
niklasad1
reviewed
Nov 11, 2022
Co-authored-by: Niklas Adolfsson <niklasadolfsson1@gmail.com>
ascjones
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.into_value()on a dynamic TX to turn it into aValuethat we can pass into other calls.This does bring to light, again, a problem with constructing nested calls in static code; the outer call will have a dynamic pallet/call index according to the node we're sending it to, but the inner call won't, and so the code won't be portable across different chains. The dynamic stuff acts as a workaround for this at the mo, but would be good to address it in static code so I'll raise an issue.
Co-Authored by @lexnv.