Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wire between Orchestrator - Provider #101
Wire between Orchestrator - Provider #101
Changes from 84 commits
776226e
5ff367e
f99f009
95816cb
92f6ccc
a8bce1d
b20050e
6a7c8de
9b010bb
7549c71
12371a2
4a02844
7aa5d07
b9004ff
ca9932a
08e2571
cf5e9ba
061abe2
c9ee23c
e993090
d0657c0
b773d9d
9ff812a
0910156
19846cb
665a447
0f28ee7
8f69cee
81a3046
c2173da
8b4bd1e
e1596d1
03862e5
dee3140
279373c
3326479
002ab11
7fd3ee6
a3a9da5
200361d
8ff4cf0
e80205c
0ad56a5
5ba4baf
a7b7660
705aaa7
9c801a3
d6bedff
7adb937
d9ee632
d656be7
8df6de3
9de861e
24dc439
a7c7da1
b430982
b4124fc
20ad6a8
417469a
2e62848
5306c5b
de6a502
9b9baa8
20fae90
037df74
5e7124c
e7ed8f5
6253202
128734f
fd57449
62c6f15
92e21d5
359b520
ff8ed13
45ced02
1e86d19
f85ac13
3a70d05
f215d2a
61089fb
0f7c960
709e0cc
5ea2b1a
545d2ac
bc89de2
ce91dc5
8fccef7
04aab70
369b8ae
a6aabee
336d3e5
6f4893f
86980c6
bbaa0b0
cbab02f
b856930
292292e
692453a
7b72636
9d7a107
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Support types needed by external users should be re-exported by the orchestrator.
we should add a
//TODO
to track this.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe having a wrapper "zombienet" crate organizing all re-exports and features could be good, wdyt ? We could use it like this:
zombienet = { version = "0.1", features = ["k8s-provider"] }
or
zombienet = { version = "0.1", features = ["native-provider" }
And at the beginning, we can defined "local-fs", "logging", and some others options as default-features
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should define a impl AddNodeOpts to build is without having to call Default::default()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this will be an external API so we can add some builder for
AddNodeOpts
. (could be in a following pr)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to fix this in some way, I have ideas about exposing a .wait method on ProviderNode and have differents implementations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is just an example entrypoint that should be replaced by the
cli
in the future.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean add some wait for each node? you also need to think that in k8s/podman we will not have a
running
process as we have in native. I think this is more an exploration we need to do as part of thecli
crate.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably hoist all dependencies to workspace Cargo.toml to enable other crates to have synchronized versions, it doesn't cost anything and make things cleaner imho, wdyt ? That way, when we need to update dependencies, we only have a single source of truth
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we should move it to the main Cargo.toml and use only the needed here. I will change it today.