Make :hackney an optional dependency

[aptinio]

This allows those who don't need to post to the coveralls.io service to reduce their dependencies. If they do try to run a Mix task that posts to coveralls.io, they are instructed to install :hackney and recompile ExCoveralls.

[coveralls]

Coverage decreased (-0.2%) to 90.347% when pulling 5e6a0ea on aptinio:optional-hackney into d1b6b35 on parroty:master.

[dmorneau]

+1, Hackney brings in a whole slew of Erlang dependencies (certifi, idna, unicode_util_compat, metrics, mimerl, parse_trans, ssl_verify_fun).

Another solution would be to post results with httpc, and support certifi or castore as optional deps for the certs. I might be able to work on this if there's interest in merging a PR.

[whatyouhide]

@parroty hey there! This is a good change IMO. Anything I can help with to get this over the finish line? Btw, would love to help out more with excoveralls, so if you need a hand feel free to shoot me an email (my email is on my GitHub profile). Cheers!

[aptinio]

@parroty, I changed the implementation so those who need to post to the coveralls.io service, only need to install :hackney and no longer need to recompile ExCoveralls, at the expense of calling Code.ensure_loaded?/1 at runtime.

It also simplifies the patch :-)

[aptinio]

@parroty, I changed back the implementation to avoid compile warnings, but made it easier to review. If there's anything you need changed to get this merged, please let me know. Thanks! :-)

[tielur]

Any progress on this? Ran into this today while installing another dependency that wants to use a newer version of certifi

[parroty]

Thanks for the follow up. Sorry about late responses 🙇 .

If they do try to run a Mix task that posts to coveralls.io, they are instructed to install :hackney

I am somewhat concerned about the behavioral change.

Another solution would be to post results with httpc, and support certifi or castore as optional deps for the certs. I might be able to work on this if there's interest in merging a PR.

This direction would be less friction approach, but haven't been able to dig deeper.

[albertored]

@parroty I thinks this can be closed since #311 has been merged

[parroty]

Thank you 🙇 . I'm closing this issue.