Merge pull request #55 from passren/0.6.3

Fix null type return with bool

pydynamodb/__init__.py

@@ -6,7 +6,7 @@
 if TYPE_CHECKING:
     from .connection import Connection
 
-__version__: str = "0.6.2"
+__version__: str = "0.6.3"
 
 # Globals https://www.python.org/dev/peps/pep-0249/#globals
 apilevel: str = "2.0"

pydynamodb/converter.py

@@ -220,7 +220,7 @@ def _to_list(self, value: Optional[List[Any]], **kwargs) -> Optional[List[Any]]:
         return coverted_
 
     def _to_null(self, value: Optional[bool], **kwargs) -> Optional[bool]:
-        return value
+        return None
 
     def _to_bool(self, value: Optional[bool], **kwargs) -> Optional[bool]:
         return value

tests/test_converter.py

@@ -243,7 +243,8 @@ def test_deserializer_map(self, converter):
         }
 
     def test_deserializer_null(self, converter):
-        assert converter.deserialize({"NULL": True})
+        assert converter.deserialize({"NULL": True}) is None
+        assert converter.deserialize({"NULL": False}) is None
 
     def test_deserializer_bool(self, converter):
         assert converter.deserialize({"BOOL": True})

tests/test_superset_dml_select.py

@@ -127,3 +127,24 @@ def test_parse_nested_select_case_4(self):
             "Statement": "SELECT col_str,col_datetime,col_num "
             + "FROM \"Issues\" WHERE key_partition = 'row_1'"
         }
+
+    def test_parse_nested_select_case_4(self):
+        sql = """
+        SELECT text_split(id,'.',1) FROM (
+            SELECT id FROM "lakefront-ingest-stg-config-table"
+        )
+        """
+        parser = SQLParser(sql, parser_class=SupersetSelect)
+        ret = parser.transform()
+
+    def test_parse_nested_select_case_5(self):
+        sql = """
+        SELECT id FROM (
+            SELECT text_split(id,'.',1) FROM (
+                SELECT id FROM "lakefront-ingest-stg-config-table"
+            )
+        ) AS virtual_table
+        GROUP BY id
+        """
+        parser = SQLParser(sql, parser_class=SupersetSelect)
+        ret = parser.transform()