Merge pull request #41 from passren/0.5.4

Remove Code Smell
passren · Sep 7, 2023 · e3c758a · e3c758a
2 parents 7b20da5 + 25a148f
commit e3c758a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/pydynamodb/superset_dynamodb/helper.py b/pydynamodb/superset_dynamodb/helper.py
@@ -33,10 +33,11 @@ def create(statement: Statement, config: QueryDBConfig = None, **kwargs) -> Quer
 
         _query_db_class = None
         if _config.db_type.lower() == DEFAULT_QUERYDB_TYPE:
-            if _config.db_url.lower() == DEFAULT_QUERYDB_URL:
-                _query_db_class = SqliteMemQueryDB
-            else:
-                _query_db_class = SqliteFileQueryDB
+            _query_db_class = (
+                SqliteMemQueryDB
+                if _config.db_url.lower() == DEFAULT_QUERYDB_URL
+                else SqliteFileQueryDB
+            )
         else:
             if _config.db_class:
                 db_apis = _config.db_class.split(":")

diff --git a/tests/test_sqlalchemy_dynamodb.py b/tests/test_sqlalchemy_dynamodb.py
@@ -183,7 +183,7 @@ def test_declarative_table_update(self, engine):
         assert rows[0][3] == 99
 
     def test_declarative_table_delete(self, engine):
-        engine, conn = engine
+        engine, _ = engine
 
         with Session(engine) as session:
             test_case = session.scalars(
@@ -319,7 +319,7 @@ def test_no_data_return(self, engine):
         assert len(rows) == 0
 
     def test_declarative_table(self, engine):
-        engine, conn = engine
+        engine, _ = engine
 
         with Session(engine) as session:
             rows1 = session.execute(