Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ansi_up #59

Merged
merged 4 commits into from
Mar 28, 2024
Merged

Update ansi_up #59

merged 4 commits into from
Mar 28, 2024

Conversation

tim-stasse
Copy link
Contributor

@tim-stasse tim-stasse commented Mar 28, 2024

  • Updates ansi_up to the equivalent upstream 6.0.2 version
  • Adds ansi-${format} classes to allow avoiding inline styles
  • Adds useAnsiClasses prop to LogViewer component, so users can drive the ansiUp.use_classes value

The main point of this change is to allow the use of class names, instead of inline styles, to avoid CSP issues.

@tim-stasse tim-stasse marked this pull request as ready for review March 28, 2024 06:18
@dlabaj dlabaj merged commit 3aedede into patternfly:main Mar 28, 2024
7 checks passed
Copy link

🎉 This PR is included in version 5.2.0-prerelease.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Jun 3, 2024

🎉 This PR is included in version 6.0.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants