Updates to make plugin work with next Redmine V4.0.0

[Utopism]

Hi,

Can you please review this pull request ?
This version is compatible with previous versions.

Thanks a lot.

[kzalewski]

I can confirm that this patch works nicely with Redmine 4.0.0. Without it, a migration to Redmine v4.0 produces a bunch of errors when executing rake db:migrate.

[Utopism]

Thank kzalewski to have tested it.

peclick, can you please merge this pull request ?

[canyildiz]

This worked great with the following environment:

Environment:
  Redmine version                4.0.1.stable
  Ruby version                   2.5.3-p105 (2018-10-18) [x86_64-linux]
  Rails version                  5.2.2
  Environment                    production
  Database adapter               PostgreSQL
  Mailer queue                   ActiveJob::QueueAdapters::AsyncAdapter
  Mailer delivery                smtp
SCM:
  Subversion                     1.9.5
  Mercurial                      4.0
  Bazaar                         2.8.0
  Git                            2.11.0
  Filesystem                     
Redmine plugins:
  clipboard_image_paste          1.13

[kou]

I confirmed that this patch works with Redmine 3.4.8 and 4.0.1.
It may be better that we add 4.0.x to supported Redmine version list in README.

[alfal]

Great ,this plugin can run again, thanks @Utopism Utopism && @kou kou

[bviktor]

Merge please :)

[AdamN1]

Hi,
can we merge this?

[petrlosa]

please merge this, this work on 4.0.3 OK

[jerome-salanhac]

work fine, thank a lot ! 👍 (redmine 4.0.3)

[Utopism]

work fine, thank a lot ! +1 (redmine 4.0.3)

You're welcome.

[shanedobson-ibboost]

This is failing for me in Redmine 4.0.4. The install and migrate works perfectly well, but when I actually attempt to click on the button to use the plugin, nothing happens. Nothing in the log either. As well as that the button isn't rendering correctly - it appears below well outside the area where it normally does.

[shanedobson-ibboost]

Actually to add to that - the 'Add picture from clipboard' button appears at the bottom of all pages on Redmine after installing this

[scottfu001]

thanks a lot, worked on 4.0.4 stable.

[shanedobson-ibboost]

Also working for me on 4.0.4 stable - permissions error from me was stopping it. Thanks!

[Nico207]

This patch work in this environment:

Redmine version : 4.0.5.stable.19319
Ruby version : 2.5.1-p57 (2018-03-29) [x86_64-linux-gnu]
Rails version : 5.2.3

Thanks a lot !

[Utopism]

This is failing for me in Redmine 4.0.4. The install and migrate works perfectly well, but when I actually attempt to click on the button to use the plugin, nothing happens. Nothing in the log either. As well as that the button isn't rendering correctly - it appears below well outside the area where it normally does.

Hi, did tried to remove old assets with :
RAILS_ENV=production rails assets:clean
Do you have any other plugin that could interfere with this one ?

[dsardelic]

Seems to be working OK in the following environment:
.

[bviktor]

Redmine 4.1 has this feature built-in, so having this plugin is pretty pointless ever since.

[dsardelic]

Redmine 4.1 has this feature built-in, so having this plugin is pretty pointless ever since.

Right you are, dear sir. Feature #3816, released in v4.1.0. Totally missed it.

[borisbrodski]

Redmine 4.1 has this feature built-in, so having this plugin is pretty pointless ever since.

This plugins is much better:

• You can crop the images
• You can give a meaningfull names to the images

So please, keep it going.

[hiroshi24da]

I agree with borisbrodski.
In addition, feature #3816 works when text formatting is markdown,
but does't work with CKEditor.
https://www.redmine.org/issues/3816#note-152

[eric-it6]

Thanks man, I think this is the only version that still works under 4.0.x. Tested under 4.0.6.

[olivierb2]

+1, working for me on redmine 4.0.7 (Debian Buster Backports official packages)