Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove map iteration from list comprehension #1726

Merged
merged 18 commits into from
Dec 26, 2022
Merged

Remove map iteration from list comprehension #1726

merged 18 commits into from
Dec 26, 2022

Conversation

raviqqe
Copy link
Contributor

@raviqqe raviqqe commented Dec 26, 2022

Close #1722.

@codecov
Copy link

codecov bot commented Dec 26, 2022

Codecov Report

Base: 88.05% // Head: 87.94% // Decreases project coverage by -0.11% ⚠️

Coverage data is based on head (8947c84) compared to base (fa7b4f3).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1726      +/-   ##
==========================================
- Coverage   88.05%   87.94%   -0.12%     
==========================================
  Files         467      467              
  Lines       55653    54614    -1039     
==========================================
- Hits        49005    48029     -976     
+ Misses       6648     6585      -63     
Impacted Files Coverage Δ
lib/format/src/lib.rs 99.44% <ø> (-0.01%) ⬇️
lib/hir-mir/src/error.rs 12.90% <ø> (+3.60%) ⬆️
lib/hir-mir/src/lib.rs 98.61% <ø> (-0.12%) ⬇️
lib/hir/src/analysis/error.rs 0.53% <ø> (+<0.01%) ⬆️
lib/parse/src/parser.rs 99.90% <ø> (-0.01%) ⬇️
lib/hir-mir/src/list_comprehension.rs 100.00% <100.00%> (+8.15%) ⬆️
lib/hir-mir/src/variant_type_collection.rs 100.00% <100.00%> (+0.52%) ⬆️
lib/hir/src/analysis/type_checker.rs 99.27% <100.00%> (+0.25%) ⬆️
lib/hir/src/analysis/type_coercer.rs 96.14% <100.00%> (-0.34%) ⬇️
lib/hir/src/analysis/type_inferrer.rs 97.04% <100.00%> (-0.01%) ⬇️
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@raviqqe raviqqe added the merge label Dec 26, 2022
@mergify mergify bot merged commit ca21508 into main Dec 26, 2022
@mergify mergify bot deleted the chore/no-map-iter branch December 26, 2022 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace map iteration in list comprehension with built-in functions
1 participant