Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix source positions in error messsages #1729

Merged
merged 22 commits into from
Dec 30, 2022
Merged

Fix source positions in error messsages #1729

merged 22 commits into from
Dec 30, 2022

Conversation

raviqqe
Copy link
Contributor

@raviqqe raviqqe commented Dec 27, 2022

Close #1728.

Todo

  • Remove the Type::set_position() function.

@codecov
Copy link

codecov bot commented Dec 30, 2022

Codecov Report

Base: 87.94% // Head: 87.91% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (0a77320) compared to base (8f98505).
Patch coverage: 80.90% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1729      +/-   ##
==========================================
- Coverage   87.94%   87.91%   -0.03%     
==========================================
  Files         467      467              
  Lines       54614    55056     +442     
==========================================
+ Hits        48029    48404     +375     
- Misses       6585     6652      +67     
Impacted Files Coverage Δ
lib/hir-mir/src/module.rs 94.19% <0.00%> (-1.28%) ⬇️
lib/hir/src/analysis/error.rs 0.54% <0.00%> (+0.01%) ⬆️
lib/hir/src/analysis/record_field_validator.rs 96.11% <25.00%> (-3.03%) ⬇️
lib/hir-mir/src/built_in_call.rs 93.67% <40.00%> (-3.57%) ⬇️
lib/hir/src/analysis/type_inferrer.rs 96.29% <55.31%> (-0.75%) ⬇️
lib/hir/src/analysis/type_coercer.rs 95.74% <55.55%> (-0.41%) ⬇️
lib/hir-mir/src/expression.rs 93.14% <70.58%> (-0.45%) ⬇️
lib/hir/src/analysis/type_extractor.rs 95.63% <82.60%> (-0.84%) ⬇️
lib/hir/src/analysis/type_checker.rs 98.49% <93.18%> (-0.79%) ⬇️
lib/hir-mir/src/downcast.rs 100.00% <100.00%> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@raviqqe raviqqe added the merge label Dec 30, 2022
@mergify mergify bot merged commit 65760ea into main Dec 30, 2022
@mergify mergify bot deleted the bug/source-position branch December 30, 2022 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong source positions in compile errors
1 participant