forked from elastic/kibana
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[Security Solution][Expandable flyout] - add onClose callback logic t…
…o Security Solution application (elastic#188196)
- Loading branch information
1 parent
6e73444
commit 09d7cfd
Showing
18 changed files
with
364 additions
and
223 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 changes: 11 additions & 0 deletions
11
x-pack/plugins/security_solution/public/flyout/document_details/shared/constants/flyouts.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| export enum Flyouts { | ||
| securitySolution = 'SecuritySolution', | ||
| timeline = 'Timeline', | ||
| } |
46 changes: 0 additions & 46 deletions
46
..._solution/public/flyout/document_details/shared/hooks/use_is_timeline_flyout_open.test.ts
This file was deleted.
Oops, something went wrong.
123 changes: 123 additions & 0 deletions
123
...s/security_solution/public/flyout/document_details/shared/hooks/use_which_flyout.test.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,123 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import type { RenderHookResult } from '@testing-library/react-hooks'; | ||
| import { renderHook } from '@testing-library/react-hooks'; | ||
| import { useWhichFlyout } from './use_which_flyout'; | ||
| import { Flyouts } from '../constants/flyouts'; | ||
|
|
||
| describe('useWhichFlyout', () => { | ||
| let hookResult: RenderHookResult<{}, string | null>; | ||
|
|
||
| beforeEach(() => { | ||
| jest.clearAllMocks(); | ||
| window.location.search = '?'; | ||
| }); | ||
|
|
||
| describe('no flyout open', () => { | ||
| it('should return null if only none are the url', () => { | ||
| Object.defineProperty(window, 'location', { | ||
| value: { | ||
| search: '', | ||
| }, | ||
| }); | ||
|
|
||
| hookResult = renderHook(() => useWhichFlyout()); | ||
|
|
||
| expect(hookResult.result.current).toEqual(null); | ||
| }); | ||
|
|
||
| it('should return null if only they are the url but empty', () => { | ||
| Object.defineProperty(window, 'location', { | ||
| value: { | ||
| search: '?flyout=()&timelineFlyout=()', | ||
| }, | ||
| }); | ||
|
|
||
| hookResult = renderHook(() => useWhichFlyout()); | ||
|
|
||
| expect(hookResult.result.current).toEqual(null); | ||
| }); | ||
|
|
||
| it('should return null if only they are the url but params are empty preview', () => { | ||
| Object.defineProperty(window, 'location', { | ||
| value: { | ||
| search: '?flyout=(preview:!())&timelineFlyout=(preview:!())', | ||
| }, | ||
| }); | ||
|
|
||
| hookResult = renderHook(() => useWhichFlyout()); | ||
|
|
||
| expect(hookResult.result.current).toEqual(null); | ||
| }); | ||
| }); | ||
|
|
||
| describe('SecuritySolution flyout open', () => { | ||
| it('should return SecuritySolution flyout if timelineFlyout is not in the url', () => { | ||
| Object.defineProperty(window, 'location', { | ||
| value: { | ||
| search: | ||
| '?flyout=(right:(id:document-details-right,params:(id:id,indexName:indexName,scopeId:scopeId)))', | ||
| }, | ||
| }); | ||
|
|
||
| hookResult = renderHook(() => useWhichFlyout()); | ||
|
|
||
| expect(hookResult.result.current).toEqual(Flyouts.securitySolution); | ||
| }); | ||
|
|
||
| it('should return SecuritySolution flyout if timelineFlyout is in the url but empty', () => { | ||
| Object.defineProperty(window, 'location', { | ||
| value: { | ||
| search: | ||
| '?flyout=(right:(id:document-details-right,params:(id:id,indexName:indexName,scopeId:scopeId)))&timelineFlyout=()', | ||
| }, | ||
| }); | ||
|
|
||
| hookResult = renderHook(() => useWhichFlyout()); | ||
|
|
||
| expect(hookResult.result.current).toEqual(Flyouts.securitySolution); | ||
| }); | ||
|
|
||
| it('should return SecuritySolution flyout if timelineFlyout is in the url but params are empty preview', () => { | ||
| window.location.search = | ||
| 'http://app/security/alerts&flyout=(right:(id:document-details-right))&timelineFlyout=(preview:!())'; | ||
|
|
||
| hookResult = renderHook(() => useWhichFlyout()); | ||
|
|
||
| expect(hookResult.result.current).toEqual(Flyouts.securitySolution); | ||
| }); | ||
| }); | ||
|
|
||
| describe('Timeline flyout open', () => { | ||
| it('should return Timeline flyout if flyout and timelineFlyout are in the url', () => { | ||
| Object.defineProperty(window, 'location', { | ||
| value: { | ||
| search: | ||
| '?flyout=(right:(id:document-details-right,params:(id:id,indexName:indexName,scopeId:scopeId)))&timelineFlyout=(right:(id:document-details-right,params:(id:id,indexName:indexName,scopeId:scopeId)))', | ||
| }, | ||
| }); | ||
|
|
||
| hookResult = renderHook(() => useWhichFlyout()); | ||
|
|
||
| expect(hookResult.result.current).toEqual(Flyouts.timeline); | ||
| }); | ||
|
|
||
| it('should return Timeline flyout if only timelineFlyout is in the url', () => { | ||
| Object.defineProperty(window, 'location', { | ||
| value: { | ||
| search: | ||
| '?timelineFlyout=(right:(id:document-details-right,params:(id:id,indexName:indexName,scopeId:scopeId)))', | ||
| }, | ||
| }); | ||
|
|
||
| hookResult = renderHook(() => useWhichFlyout()); | ||
|
|
||
| expect(hookResult.result.current).toEqual(Flyouts.timeline); | ||
| }); | ||
| }); | ||
| }); |
Oops, something went wrong.