Add support for TB115 and TB128 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterfab9845
requested changes
Aug 18, 2024
|
Thanks for making these changes, and sorry for the delay. I didn't realize forks aren't automatically watched, so I didn't get any notification of this PR. |
|
Thanks, tested on 115.14.0 and it looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the new custom column support for add-ons. It still uses an Experiment, because the new method has not yet been made available through a WebExtension API.
The add-on currently uses a generic header-columns-API which covers a lot of special cases. This PR replaces that API by a very simple minimal Experiment, which covers just the use case for the original-to-column add-on.