Add pex3 lock export-subset.
#2145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to lack of foresight, `pex3 lock export` has a CLI that is poisoned for use in a consistent way with the rest of PEX while at the same time introducing subset support; so an `export-subset` subcommand is broken out sharing the vast majority of the `export` code. This is immediately useful to a-scie/lift for supporting Pex lock files on Windows where there is no Pex support yet but seems useful in general on the same interoperability front the `export` goal was introduced for: speaking the ~lingua-franca of Pip.
|
The code and tests lgtm. I'm not an expert as to how |
zmanji
approved these changes
May 4, 2023
stuhood
approved these changes
May 5, 2023
benjyw
approved these changes
May 5, 2023
There was a problem hiding this comment.
Do I understand correctly that the CLI poison is the use of a positional arg for the lockfile, while also wanting to use positional args for the requirement subset? It would be possible to have the first positional arg be the lockfile and subsequent ones be the requirements, no? I agree that is janky though.
|
Exactly. Yeah, that seems like a confusing, or at least easy to get wrong, interface for users. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to lack of foresight,
pex3 lock exporthas a CLI that is poisonedfor use in a consistent way with the rest of PEX while at the same time
introducing subset support; so an
export-subsetsub-command is brokenout sharing the vast majority of the
exportcode.This is immediately useful to a-scie/lift for supporting Pex lock files
on Windows where there is no Pex support yet but seems useful in general
on the same interoperability front the
exportgoal was introduced for:speaking the ~lingua-franca of Pip.