Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle .tar.bz2 & .tgz sdists when locking. #2380

Merged
merged 5 commits into from
Feb 29, 2024
Merged

Conversation

jsirois
Copy link
Member

@jsirois jsirois commented Feb 29, 2024

More generally, investigate what is out there (on PyPI) for sdists and
explicitly admit .zip, .tar.gz, .tar.bz2 and .tgz as covering
99.999% of all known cases.

Fixes #2379

More generally, investigate what is out there (on PyPI) for sdists and
explicitly admit `.zip`, `.tar.gz`, `.tar.bz2` and `.tgz` as covering
99.999% of all known cases.

Fixes pex-tool#2379
It seems to be the case that PEP-658 metadata is backfilling which
triggers bugs in the legacy resolver under Pip 23.2.
@jsirois
Copy link
Member Author

jsirois commented Feb 29, 2024

1265a73 is from #2373 and is an unrelated CI bitrot fix being applied here as well to get green CI and a release in short order.

Copy link
Collaborator

@zmanji zmanji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Collaborator

@huonw huonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool; it's hard in the Python jungle.

CHANGES.md Outdated Show resolved Hide resolved
Co-authored-by: Huon Wilson <wilson.huon@gmail.com>
@jsirois jsirois merged commit a09e83e into pex-tool:main Feb 29, 2024
26 checks passed
@jsirois jsirois deleted the issues/2379 branch February 29, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lock create doesn't support tar.bz2 extensions
4 participants