Add --site-packages-copies for external venvs.
#2470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a venv external to the `PEX_ROOT` via either `pex3 venv create ...` or `PEX_TOOLS=1 ./my.pex venv ...` you can now specify `--site-packages-copies` to ensure all code populated in the venv is isolated from the `PEX_ROOT` cache. Although this takes more space on disk, it may make sense to use when you expect the venv might be tampered with or used for experimentation that might alter its files; otherwise contaminating the `PEX_ROOT` cache. Fixes pex-tool#2313
|
🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating a venv external to the
PEX_ROOTvia eitherpex3 venv create ...orPEX_TOOLS=1 ./my.pex venv ...you can nowspecify
--site-packages-copiesto ensure all code populated in thevenv is isolated from the
PEX_ROOTcache. Although this takes morespace on disk, it may make sense to use when you expect the venv might
be tampered with or used for experimentation that might alter its files;
otherwise contaminating the
PEX_ROOTcache.Fixes #2313