Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PEX info to the PEX repl. #2496

Merged
merged 6 commits into from
Aug 8, 2024
Merged

Add PEX info to the PEX repl. #2496

merged 6 commits into from
Aug 8, 2024

Conversation

jsirois
Copy link
Member

@jsirois jsirois commented Aug 6, 2024

It should now be clear when you've dropped into a PEX repl (vs. a plain
Python repl). This may help stem some of the confusion brough about by
running pex with no arguments. In addition, you gain some
introspection capabilities via the pex_info REPL command.

Fixes #157

@jsirois
Copy link
Member Author

jsirois commented Aug 7, 2024

For the #157 OP case of running a PEX pex with no args:
image

And the more general case of a normal PEX repl built via:

:; pex --interpreter-constraint ">=3.8" --pip-version latest requests --sh-boot -orequests.pex

image

@jsirois jsirois requested review from zmanji, benjyw and huonw August 7, 2024 21:59
@jsirois
Copy link
Member Author

jsirois commented Aug 7, 2024

Reviewers, another big one - but broken up into its bits anyhow. Thanks in advance.

This will probably be the last of these. It's not clear to me review makes much sense anymore except when I actually have questions you might help answer. I don't really like lobbing these things at you guys and I'm sure you don't enjoy being lobbed at.

@jsirois jsirois marked this pull request as ready for review August 7, 2024 22:04
Copy link
Collaborator

@benjyw benjyw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Splitting this into multiple coherent commits made it quite straightforward to review, thanks for that!

@benjyw
Copy link
Collaborator

benjyw commented Aug 8, 2024

Reviewers, another big one - but broken up into its bits anyhow. Thanks in advance.

This will probably be the last of these. It's not clear to me review makes much sense anymore except when I actually have questions you might help answer. I don't really like lobbing these things at you guys and I'm sure you don't enjoy being lobbed at.

I am happy to do any code reviews that are actually useful to you! Or when you think it might improve something. But just rubber-stamping makes little sense, I agree.

@jsirois jsirois merged commit e719bac into pex-tool:main Aug 8, 2024
26 checks passed
@jsirois jsirois deleted the issues/157 branch August 8, 2024 03:58
jsirois added a commit to jsirois/pex that referenced this pull request Aug 8, 2024
This extracts the large venv PEX formatted code blob to its own file for
standard formatting, linting and type check treatment. Also clean up
small bits of PEX venv repl code from pex-tool#2496.
jsirois added a commit that referenced this pull request Aug 8, 2024
This extracts the large venv PEX formatted code blob to its own file for
standard formatting, linting and type check treatment. Also clean up
small bits of PEX venv repl code from #2496.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

First example in docs doesn't work (or I'm understanding it wrong?)
2 participants