-
-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PEX info to the PEX repl. #2496
Conversation
For the #157 OP case of running a PEX pex with no args: And the more general case of a normal PEX repl built via: :; pex --interpreter-constraint ">=3.8" --pip-version latest requests --sh-boot -orequests.pex |
Reviewers, another big one - but broken up into its bits anyhow. Thanks in advance. This will probably be the last of these. It's not clear to me review makes much sense anymore except when I actually have questions you might help answer. I don't really like lobbing these things at you guys and I'm sure you don't enjoy being lobbed at. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Splitting this into multiple coherent commits made it quite straightforward to review, thanks for that!
I am happy to do any code reviews that are actually useful to you! Or when you think it might improve something. But just rubber-stamping makes little sense, I agree. |
This extracts the large venv PEX formatted code blob to its own file for standard formatting, linting and type check treatment. Also clean up small bits of PEX venv repl code from pex-tool#2496.
This extracts the large venv PEX formatted code blob to its own file for standard formatting, linting and type check treatment. Also clean up small bits of PEX venv repl code from #2496.
It should now be clear when you've dropped into a PEX repl (vs. a plain
Python repl). This may help stem some of the confusion brough about by
running
pex
with no arguments. In addition, you gain someintrospection capabilities via the
pex_info
REPL command.Fixes #157