closable option is added #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imcvampire
approved these changes
Mar 11, 2019
imcvampire
requested changes
Mar 11, 2019
|
Hi @mudin, thank you for your contribution. 1 more request: can you update docs too? Thank you! |
|
By the way, we use |
|
@imcvampire @pexea12 Thank you for your reviews! I updated the code. Please check it once more |
imcvampire
approved these changes
Mar 12, 2019
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using this for fullscreen gallery viewer and I have nothing behind,
It means I never want to close it.
I noticed that closable option is needed for such cases.