Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[alpha_shape] fixing PLSQL #2145

Merged
merged 1 commit into from
Sep 25, 2021
Merged

[alpha_shape] fixing PLSQL #2145

merged 1 commit into from
Sep 25, 2021

Conversation

bkrit
Copy link
Contributor

@bkrit bkrit commented Sep 25, 2021

Fixes #2122

Changes proposed in this pull request:

  • changed the sql and result files to fix the codacy PLSQL errors/warnings

@pgRouting/admins

@bkrit bkrit self-assigned this Sep 25, 2021
@bkrit bkrit added the OSD Open Source Day label Sep 25, 2021
@bkrit bkrit added this to the Release 3.3.0 milestone Sep 25, 2021
@dkastl
Copy link
Member

dkastl commented Sep 25, 2021

Thanks for your help to improve pgRouting! But what is the purpose of this change? -- is a common way to comment lines in plpsql.

@bkrit
Copy link
Contributor Author

bkrit commented Sep 25, 2021

Thanks for your help to improve pgRouting! But what is the purpose of this change? -- is a common way to comment lines in plpsql.

This change has been done to fix the codacy PLSQL errors/warnings as mentioned in #2120

@dkastl
Copy link
Member

dkastl commented Sep 25, 2021

Oh, I see. Thanks for referring to the issue.

cvvergara
cvvergara approved these changes Sep 25, 2021
View reviewed changes
Copy link
Member

@cvvergara cvvergara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution to pgRouting

@bkrit bkrit merged commit ca992b4 into pgRouting:develop Sep 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvvergara cvvergara cvvergara approved these changes

Assignees

@bkrit bkrit

Labels
OSD Open Source Day
Projects
None yet
Milestone
Release 3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@bkrit @dkastl @cvvergara