Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning clang fix dev #2265

Merged
merged 2 commits into from
Apr 5, 2022
Merged

Conversation

cvvergara
Copy link
Member

Fixes #2216 .

Changes proposed in this pull request:

  • Modified src code to eliminate warnings

@pgRouting/admins

@krashish8
Copy link
Member

Whenever I look at types like II_t_rt, I wonder what's the meaning of it. I need to go back and check for similar types in the include/c_types directory (i_rt.h, ii_t_rt.h, iid_t_rt.h) to understand it's meaning.

Would it be better if full names were used in the types, or can we document or generalize this for better understanding?

I_rt contains a single integer.
IID_t_rt contains two integers and a double type.
But II_t_rt contains two "union" types, each of which contains 3 integers. It looks it should have been "two integers" instead, if we try to generalize it using the short form names.

@cvvergara cvvergara merged commit b6f2e13 into pgRouting:develop Apr 5, 2022
@cvvergara cvvergara deleted the warning-clang-fix-dev branch April 5, 2022 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants