Replace NW.js with Electron

[adityatoshniwal]

No description provided.

[adityatoshniwal]

TODO: If possible, rebrand Electron Helper processes to pgAdmin.

[adityatoshniwal]

On MacOS, Preferences will be automatically renamed to Settings.... Check - electron/electron#42583

[akshay-joshi]

Found a few issues during testing:

1. Preferences rename to Settings in OSX. On Windows it is Preferences.
2. Configure runtime and view log's inner container height should be corrected.
3. Open Query Tool in a new window, type some query and try to close this window. It asks for "Don't save" and "Save" click on any button, and the new window won't close at all. Reproduced only on Windows, OSX working fine.

[adityatoshniwal]

@akshay-joshi for Preferences named as Settings please check my above comment - #7494 (comment)

[akshay-joshi]

But we should be consistent, is there any way to change it to Preferences?

[pravesh-sharma]

Facing an issue with the file dialog. Below are steps to reproduce:

1. Open the backup/restore dialog and click on the file icon to open the file dialog
2. Input a file name and click on the save button.

Nothing happens

Expected behaviour:
The file name with the complete path should appear on input. Also, file extension is not present which was there earlier

Screen.Recording.2024-07-04.at.10.20.09.AM.mov

[yogeshmahajan-1903]

1.Try starting debugging for function from tools > Debugging option by selecting function. Seems to be error for the all callbacks functions.(From context menu works fine.)

2.Windows > zoom > minimises screen. Error in developer console.

[pravesh-sharma]

Menu options inside Object -> Create not working.

[yogeshmahajan-1903]

1.Try starting debugging for function from tools > Debugging option by selecting function. Seems to be error for the all callbacks functions.(From context menu works fine.)

Works fine

2.Windows > zoom > minimises screen. Error in developer console.

@adityatoshniwal This is not yet fixed

3.Unable to close pgadmin (On 9 July snapshot)
a.Open pgAdmin
b.Open query tool, execute some query.
c.Navigate to other tab.
d.Try closing pgadmin
e.pgadmin does not close as , there is confirmation pop up is waiting for response in query too.

[adityatoshniwal]

Hi @yogeshmahajan-1903,
Isn't this an expected behaviour? Why should pgAdmin close if it is confirming for closing query tool first? In fact, this is a missing feature I would say.

[adityatoshniwal]

@yogeshmahajan-1903 You can ignore the Windows > zoom > minimises screen error. It comes from third party code and not from pgAdmin and it doesn't affect pgAdmin usability

[yogeshmahajan-1903]

Hi @yogeshmahajan-1903, Isn't this an expected behaviour? Why should pgAdmin close if it is confirming for closing query tool first? In fact, this is a missing feature I would say.

Problem is that, pop up does not come on screen.it is stick to query tool tab only.

[adityatoshniwal]

Hi @yogeshmahajan-1903, Isn't this an expected behaviour? Why should pgAdmin close if it is confirming for closing query tool first? In fact, this is a missing feature I would say.

Problem is that, pop up does not come on screen.it is stick to query tool tab only.

Each query tool will have its own pop-up, consider the case where there are multiple query tools open.

[yogeshmahajan-1903]

1.Open query tool and click on close button for pgadmin. It closed query tool

[anilsahoo20]

@adityatoshniwal When I try to close the ERD tool tab, it's not closing. Apart from that all other tool tabs and basic tabs gets closed on click of close icon of a tab.

[RohitBhati8269]

ERD tool on Mac OS (Server Mode):-

1. when we create a test object for ERD and then press the save button shortcut multiple times, it opens numerous save dialogs.
2. When I do that same thing for QueryToll, it first opens an application save dialog. Then if we again press (cmd + s), it opens a system save dialog on top of the application save dialog.

ERD tool on On Linux (Server Mode):-

1. On the ERD tool save button shortcut(ctrl + s) always opens a system save dialog, not an application save dialog.

[yogeshmahajan-1903]

1.On windows, I could open 4 pgAdmin4 instances. by 4/5 times clicking icon. (Same case with Edge also). It's nice if we can prevent that.

2.On windows, it seems , top padding required for menu bar items.

[adityatoshniwal]

@yogeshmahajan-1903 I searched for header sizing and found that it is bug in Electron on windows - electron/electron#27651

[yogeshmahajan-1903]

1.After changing runtime settings, clicking yes on app quit dialogue does not quit application

[yogeshmahajan-1903]

1.Addtional space in logs dialogue -

Same for configure runtime

[adityatoshniwal]

1.Addtional space in logs dialogue -

if there is something more important then I will reduce the space along with that. For now, I will not add any commit for this.
In fact, it looks fine on Mac. We can't/shouldn't add conditions based on OS for this small space.

[yogeshmahajan-1903]

In full screen mode, menu bar disappears on Ubuntu -

[akshay-joshi]

Tested on candidate build.