Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added all supported index storage parameters while creating an index. #6374 #6534

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

pravesh-sharma
Copy link
Contributor

No description provided.

Copy link
Contributor

@akshay-joshi akshay-joshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Put all the Storage Parameters in a nested fieldset with the label "With".
  2. Check deduplicate_items parameter should not be included in the SQL for versions less than 13.
  3. For fillfactor and pages_per_range we are resetting the parameter in the ALTER command, we should do the same for all the other storage parameters (deduplicate_items, fastupdate, autosummarize) when the value is set to False.
  4. API tests are failing on v12 and v13

@pravesh-sharma
Copy link
Contributor Author

  • Put all the Storage Parameters in a nested fieldset with the label "With".
  • Check deduplicate_items parameter should not be included in the SQL for versions less than 13.
  • For fillfactor and pages_per_range we are resetting the parameter in the ALTER command, we should do the same for all the other storage parameters (deduplicate_items, fastupdate, autosummarize) when the value is set to False.
  • API tests are failing on v12 and v13
  • I have made all the changes. However, we can not reset the values of deduplicate_items, fastupdate, autosummarize on selecting false as user may want to set the value as false.
  • I ran API test cases on my machine and it is not failing.

@akshay-joshi akshay-joshi merged commit ab0b1dd into pgadmin-org:master Jul 11, 2023
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants