Vimium isn't disabled in cross-origin subframes of excluded documents.

[kashav]

Describe the bug
Vimium isn't disabled in cross-origin subframes of excluded documents.

To Reproduce

1. Add https://developer.mozilla.org/* to the exclude list in Vimium options.
2. Go to https://developer.mozilla.org/en-US/docs/Web/HTML/Element/iframe. Type i (or ?, or anything else to test if Vimium is enabled). Notice that Vimium isn't enabled, which is as expected.
3. Focus either of the iframes in the first demo (both the container and the map are embedded on different sites, so either works).
4. Type i and notice that Vimium is still enabled in the frame.

Browser and Vimium version
Firefox 96.0a1, but this reproduces in both Firefox and Chrome. Vimium 1.67.

[gdh1995]

In this case Vimium works as intended - exclusion rules are computed on every frame, but not on a tab.

[kashav]

Okay, I see. Any reason to not exclude Vimium in a subframe if it's excluded in the embedder?

[gdh1995]

um, maybe in case both an outer frame and an inner frame have matched rules.

…

---Original--- From: "kashav ***@***.***> Date: Sat, Nov 20, 2021 11:31 AM To: ***@***.***>; Cc: "Dahan ***@***.******@***.***>; Subject: Re: [philc/vimium] Vimium isn't disabled in cross-origin subframes of excluded documents. (Issue #3960) Okay, I see. Any reason to not exclude Vimium in a subframe if it's excluded in the embedder? — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.