Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(completion): adds man page search, completion #4091

Closed
wants to merge 4 commits into from
Closed

feat(completion): adds man page search, completion #4091

wants to merge 4 commits into from

Conversation

nicoandmee
Copy link

Description

I am a big fan of this project and humbly request this PR for consideration.

It adds support for man page completion by way of mankier. This site is very useful for reading command documentation in the browser. Here is an example of such a man page.

  • This was relatively straightforward to accomplish by way of extending the completion BaseEngine.

Small refactor to use Fetch instead of XMLHttpRequest. I did this for two reasons:

  • The MV3 spec requires that the background script use Fetch, as SW has no access to XMLHttpRequest.
  • XMLHttpRequest has no equivalent of mode - without which API calls to the ManKier endpoint will fail, due to a CSP violation.

Thank you!

Please review the "Which pull requests get merged?" section in CONTRIBUTING.md.

@nicoandmee nicoandmee changed the title feat(completion): adds mankier search, completion feat(completion): adds man page search, completion Jul 25, 2022
@nicoandmee
Copy link
Author

@philc 👀

@nicoandmee
Copy link
Author

@philc Any interest in getting this merged in the new year?

@aamehedi
Copy link

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants